rorueda commented on PR #3977: URL: https://github.com/apache/calcite/pull/3977#issuecomment-2373722695
Summarizing the changes after more issues were discovered (check jira for details): EnumUtils: - Split the code paths of compact code and normal code. It sacrifices a bit of code reuse, but it makes it clearer and minimizes the chance of adding bugs to the normal code path. - On the compact code path, remove the "optimization" of generating an array of a specific type if all output fields are of the same type - I don't think there is any benefit in doing this and the normal code path also doesn't seem to do this. JavaRowType: - Make the `copy` method abstract (the default implementation, disregarding the different types, was the big issue). - Implement a specific `copy` for every `JavaRowType`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
