rubenada commented on code in PR #4000:
URL: https://github.com/apache/calcite/pull/4000#discussion_r1793791803
##########
core/src/main/java/org/apache/calcite/tools/RelBuilder.java:
##########
@@ -2896,6 +2896,9 @@ private static List<RexLiteral>
convertLiteralTypes(RelOptCluster cluster,
RelDataType rowType, List<RexLiteral> values) {
assert values.size() == rowType.getFieldCount();
RexExecutor executor = cluster.getPlanner().getExecutor();
+ if (executor == null) {
+ executor = RexUtil.EXECUTOR;
+ }
if (executor == null) {
Review Comment:
I think @NobiGo means that currently the patch code is:
```
if (executor == null) {
executor = RexUtil.EXECUTOR;
}
if (executor == null) {
return values;
}
```
The second `if` could be removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
