arkanovicz commented on PR #4016: URL: https://github.com/apache/calcite/pull/4016#issuecomment-2439764821
> 1. Building AggCall with RelBuilder IIUC, RelBuilder uses an intermediate AggCall construct, I'm not sure that this is needed here. > 2. It seems that no multiple arguments AggCall is converted in this rule except for _Count_. Therefore, `origCall.getArgList().size() ! = 1` can be used as an assertion that alerts people to the need to redesign this part if they extend other AggFunctions in the future Done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
