suibianwanwank commented on code in PR #4023:
URL: https://github.com/apache/calcite/pull/4023#discussion_r1822707914
##########
core/src/main/java/org/apache/calcite/sql/validate/implicit/AbstractTypeCoercion.java:
##########
@@ -280,6 +280,13 @@ protected boolean needToCast(SqlValidatorScope scope,
SqlNode node,
return false;
}
+ if (node.getKind() == SqlKind.LITERAL
Review Comment:
Thanks for the review, I agree that the cast prior to this pr is correct.
The problem I'm trying to solve doesn't conflict with this, I'll close this PR
and re-edit the issue.
BTW, for the raggedUnionTypesToVarying setting in your PR, that's what I've
been puzzled about as well. And for the CHAR type cast, I once mentioned an
ISSUE for that as well, [CALCITE-6520], and I'm not sure if your PR addresses
that as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
