suibianwanwank commented on code in PR #4033:
URL: https://github.com/apache/calcite/pull/4033#discussion_r1828680588
##########
babel/src/test/resources/sql/big-query.iq:
##########
@@ -1594,13 +1594,13 @@ WITH letters AS
SELECT 'b c d' as letter_group)
SELECT SPLIT(letter_group, ' ') as example
FROM letters;
-+-----------+
-| example |
-+-----------+
-| [] |
-| [a] |
-| [b, c, d] |
-+-----------+
++--------------+
Review Comment:
The test results here look a little strange, but this seems to be as
expected. [PR-4024] Changed raggedUnionTypesToVarying, which will fix the
problem
##########
babel/src/test/resources/sql/big-query.iq:
##########
@@ -1647,8 +1647,8 @@ FROM letters;
+-----------+
| example |
+-----------+
-| [] |
-| [A] |
+| [�����] |
Review Comment:
I'm not familiar with the binray type, but from the plan it makes sense.But
the execution result is not what I expected and I don't know where BabelTest is
executed.
```
LogicalProject(example=[SPLIT($0, X'ff':BINARY(1))])
LogicalValues(tuples=[[{ X'0000000000' }, { X'4100000000' }, {
X'42ff43ff44' }]])
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
