caicancai commented on code in PR #4032:
URL: https://github.com/apache/calcite/pull/4032#discussion_r1830259351
##########
arrow/src/main/java/org/apache/calcite/adapter/arrow/ArrowTranslator.java:
##########
@@ -133,6 +133,15 @@ private String translateMatch2(RexNode node) {
return translateUnary("isnull", (RexCall) node);
case IS_NOT_NULL:
return translateUnary("isnotnull", (RexCall) node);
+ case IS_NOT_TRUE:
+ return translateUnary("isnottrue", (RexCall) node);
+ case IS_NOT_FALSE:
+ return translateUnary("isnotfalse", (RexCall) node);
+ case INPUT_REF:
Review Comment:
I thought about it and it is OK to translate is true. Calcite will trim
simple is true, such as `where 1 is true`, because they are all constants. But
`booleanField is true `is obviously not.
@mihaibudiu What do you think?
##########
arrow/src/main/java/org/apache/calcite/adapter/arrow/ArrowTranslator.java:
##########
@@ -133,6 +133,15 @@ private String translateMatch2(RexNode node) {
return translateUnary("isnull", (RexCall) node);
case IS_NOT_NULL:
return translateUnary("isnotnull", (RexCall) node);
+ case IS_NOT_TRUE:
+ return translateUnary("isnottrue", (RexCall) node);
+ case IS_NOT_FALSE:
+ return translateUnary("isnotfalse", (RexCall) node);
+ case INPUT_REF:
Review Comment:
I thought about it and it is OK to translate is true. Calcite will trim
simple is true, such as `where 1 is true`, because they are all constants. But
`booleanField is true `is obviously not.
@mihaibudiu What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
