caicancai commented on PR #4037: URL: https://github.com/apache/calcite/pull/4037#issuecomment-2462118405
> I guess its fine to merge this change but the benefits are not clear. The code was already readable before and the "perf gain" from moving the check will hardly make any real perf difference. Unfortunately, Calcite does not have a benchmark similar to benchmark -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
