caicancai commented on code in PR #4034:
URL: https://github.com/apache/calcite/pull/4034#discussion_r1832688243


##########
core/src/main/java/org/apache/calcite/sql2rel/RelDecorrelator.java:
##########
@@ -208,6 +210,25 @@ public static RelNode decorrelateQuery(RelNode rootRel) {
    */
   public static RelNode decorrelateQuery(RelNode rootRel,
       RelBuilder relBuilder) {
+    return decorrelateQuery(rootRel, relBuilder, DEFAULT_DECORRELATE_RULES);
+  }
+
+  /**
+   * Decorrelates a query specifying a collection of rules to be used in the
+   * "remove correlation via rules" pre-processing.
+   *
+   * @param rootRel           Root node of the query
+   * @param relBuilder        Builder for relational expressions
+   * @param decorrelateRules  Rules to be used in the decorrelation
+   *
+   * @return Equivalent query with all
+   * {@link org.apache.calcite.rel.core.Correlate} instances removed
+   *
+   * @see #removeCorrelationViaRule(RelNode, Collection)
+   */

Review Comment:
   The JavaDocs are very nice, thanks a lot



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to