caicancai commented on code in PR #4032:
URL: https://github.com/apache/calcite/pull/4032#discussion_r1833521085
##########
arrow/src/main/java/org/apache/calcite/adapter/arrow/ArrowTranslator.java:
##########
@@ -114,7 +114,13 @@ private List<String> translateAnd(RexNode condition) {
return predicates;
}
- /** Translate a binary or unary relation. */
+ /**
+ * Translates a binary or unary relation.
+ *
+ * @param node A RexNode that always evaluates to a boolean expression.
+ * Currently, this method is only called from translateAnd.
Review Comment:
Thank you very much for your advice, I am supporting CNF, but it seems that
my thinking is wrong.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
