mihaibudiu commented on code in PR #4039:
URL: https://github.com/apache/calcite/pull/4039#discussion_r1834794014
##########
core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java:
##########
@@ -3877,13 +3883,41 @@ public static double lesser(double b0, double b1) {
return b0 > b1 ? b1 : b0;
}
+ public static @Nullable <T extends Comparable<T>> List<T> lesser(
+ @Nullable List<T> b0, @Nullable List<T> b1) {
+ if (b0 == null) {
+ return b1;
+ }
+ if (b1 == null) {
+ return b0;
+ }
+ return lt(b0, b1) ? b0 : b1;
+ }
+
+ public static @Nullable <T extends Comparable<T>> List<T> greater(
Review Comment:
there are at least 10 versions of this function in this file, which share
one common comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
