mihaibudiu commented on code in PR #4045: URL: https://github.com/apache/calcite/pull/4045#discussion_r1839627818
########## site/_docs/reference.md: ########## @@ -2785,7 +2785,7 @@ In the following: | * | CSC(numeric) | Returns the cosecant of *numeric* in radians | * | CSCH(numeric) | Returns the hyperbolic cosecant of *numeric* | b | CURRENT_DATETIME([ timeZone ]) | Returns the current time as a TIMESTAMP from *timezone* -| m | DAYNAME(datetime) | Returns the name, in the connection's locale, of the weekday in *datetime*; for example, it returns '星期日' for both DATE '2020-02-10' and TIMESTAMP '2020-02-10 10:10:10' +| m | DAYNAME(datetime) | Returns the name, in the connection's locale, of the weekday in *datetime*; for example, if you config locale to en, it will return 'Sunday' for both DATE '2020-02-10' and TIMESTAMP '2020-02-10 10:10:10', and if you config locale to zh, it will return '星期日' Review Comment: I think an impersonal sentence is preferrable, i.e., without "you" "For a locale of en it will return 'Sunday'" etc. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
