caicancai commented on code in PR #4044:
URL: https://github.com/apache/calcite/pull/4044#discussion_r1844883458
##########
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##########
@@ -3419,8 +3423,10 @@ static void checkOverlaps(OverlapChecker c) {
}
@Test void testMultiplyOperator() {
- final SqlOperatorFixture f = fixture();
- f.setFor(SqlStdOperatorTable.MULTIPLY, VmName.EXPAND);
+ final SqlOperatorFixture f = fixture()
+ .setFor(SqlStdOperatorTable.MULTIPLY, VmName.EXPAND)
+ // BigQuery requires arithmetic overflows
Review Comment:
just bigquery?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
