caicancai commented on code in PR #4052:
URL: https://github.com/apache/calcite/pull/4052#discussion_r1845747808
##########
arrow/src/main/java/org/apache/calcite/adapter/arrow/ArrowFieldType.java:
##########
@@ -25,27 +25,17 @@
import java.math.BigDecimal;
import java.sql.Date;
-import java.util.List;
import static java.util.Objects.requireNonNull;
/**
* Arrow field type.
*/
-enum ArrowFieldType {
- INT(Primitive.INT),
- BOOLEAN(Primitive.BOOLEAN),
- STRING(String.class),
- FLOAT(Primitive.FLOAT),
- DOUBLE(Primitive.DOUBLE),
- DATE(Date.class),
- LIST(List.class),
- DECIMAL(BigDecimal.class),
- LONG(Primitive.LONG),
- BYTE(Primitive.BYTE),
- SHORT(Primitive.SHORT);
+class ArrowFieldType {
Review Comment:
Later, I may dynamically pass some parameters according to the data type of
arrow, which is difficult to achieve through enumeration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
