mihaibudiu commented on code in PR #4066:
URL: https://github.com/apache/calcite/pull/4066#discussion_r1861144990
##########
core/src/main/java/org/apache/calcite/sql2rel/ConvertToChecked.java:
##########
@@ -92,8 +98,7 @@ static class ConvertRexToChecked extends RexShuttle {
result = call;
}
return builder.makeCast(call.getType(), result);
- } else if (!SqlTypeName.EXACT_TYPES.contains(resultType)
- || (resultType == SqlTypeName.DECIMAL)) {
Review Comment:
turns out that the second condition in the OR can never be true since it is
covered by the previous if.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
