(calcite) branch main updated: Typos in SqlOperatorTest

[xiong]

This is an automated email from the ASF dual-hosted git repository.

xiong pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/calcite.git


The following commit(s) were added to refs/heads/main by this push:
     new b69b753625 Typos in SqlOperatorTest
b69b753625 is described below

commit b69b753625a496425ee528f97eb140efae928721
Author: Xiong Duan <nobigo...@gmail.com>
AuthorDate: Sat Nov 30 08:14:13 2024 +0800

    Typos in SqlOperatorTest
---
 .../org/apache/calcite/test/SqlOperatorTest.java   | 30 ++++++++++++----------
 1 file changed, 17 insertions(+), 13 deletions(-)

diff --git a/testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java 
b/testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java
index 1ddb005a29..13e96d4bc0 100644
--- a/testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java
+++ b/testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java
@@ -2187,20 +2187,24 @@ public class SqlOperatorTest {
 
   @Test void testChar() {
     final SqlOperatorFixture f0 = fixture()
-        .setFor(SqlLibraryOperators.CHR, VM_JAVA);
+        .setFor(SqlLibraryOperators.CHAR, VM_JAVA);
     f0.checkFails("^char(97)^",
         "No match found for function signature CHAR\\(<NUMERIC>\\)", false);
-    final SqlOperatorFixture f = f0.withLibrary(SqlLibrary.MYSQL);
-    f.checkScalar("char(null)", isNullValue(), "CHAR(1)");
-    f.checkScalar("char(-1)", isNullValue(), "CHAR(1)");
-    f.checkScalar("char(97)", "a", "CHAR(1)");
-    f.checkScalar("char(48)", "0", "CHAR(1)");
-    f.checkScalar("char(0)", String.valueOf('\u0000'), "CHAR(1)");
-    f.checkFails("^char(97.1)^",
-        "Cannot apply 'CHAR' to arguments of type 'CHAR\\(<DECIMAL\\(3, 
1\\)>\\)'\\. "
-            + "Supported form\\(s\\): 'CHAR\\(<INTEGER>\\)'",
-        false);
-    f.checkNull("char(null)");
+    final Consumer<SqlOperatorFixture> consumer = f -> {
+      f.checkScalar("char(null)", isNullValue(), "CHAR(1)");
+      f.checkScalar("char(-1)", isNullValue(), "CHAR(1)");
+      f.checkScalar("char(97)", "a", "CHAR(1)");
+      f.checkScalar("char(48)", "0", "CHAR(1)");
+      f.checkScalar("char(0)", String.valueOf('\u0000'), "CHAR(1)");
+      f.checkFails("^char(97.1)^",
+          "Cannot apply 'CHAR' to arguments of type 'CHAR\\(<DECIMAL\\(3, 
1\\)>\\)'\\. "
+              + "Supported form\\(s\\): 'CHAR\\(<INTEGER>\\)'",
+          false);
+      f.checkNull("char(null)");
+    };
+    final List<SqlLibrary> libraries =
+        list(SqlLibrary.MYSQL, SqlLibrary.SPARK);
+    f0.forEachLibrary(libraries, consumer);
   }
 
   @Test void testChr() {
@@ -10838,7 +10842,7 @@ public class SqlOperatorTest {
 
   @Test void testInstrFunction() {
     final SqlOperatorFixture f0 = fixture()
-        .setFor(SqlLibraryOperators.CHR, VM_JAVA);
+        .setFor(SqlLibraryOperators.INSTR, VM_JAVA);
     f0.checkFails("^INSTR('abc', 'a', 1, 1)^",
         "No match found for function signature INSTR\\(<CHARACTER>, 
<CHARACTER>,"
             + " <NUMERIC>, <NUMERIC>\\)", false);