mihaibudiu commented on code in PR #4074:
URL: https://github.com/apache/calcite/pull/4074#discussion_r1866417326


##########
core/src/main/java/org/apache/calcite/sql/fun/SqlLibraryOperators.java:
##########
@@ -1166,7 +1166,14 @@ static RelDataType deriveTypeSplit(SqlOperatorBinding 
operatorBinding,
           SqlKind.OTHER_FUNCTION,
           ReturnTypes.BIGINT_NULLABLE,
           null,
-          OperandTypes.NUMERIC.or(OperandTypes.BINARY),
+          OperandTypes.or(OperandTypes.NUMERIC,
+              OperandTypes.BINARY,
+              OperandTypes.BOOLEAN,
+              OperandTypes.CHARACTER,
+              OperandTypes.DATETIME,

Review Comment:
   you have here more types than the JIRA title promises.
   Also, it seems from the JIRA comments that you are not really supporting 
these other types yet.
   
   The solution for the question you asked in the JIRA is to pass some type 
information to the runtime. If the input is a Date, you need to pass a "DATE" 
flag to the runtime so that it interprets the integer as a date.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to