alex-plekhanov commented on code in PR #4076:
URL: https://github.com/apache/calcite/pull/4076#discussion_r1870158027
##########
core/src/main/java/org/apache/calcite/rex/RexBuilder.java:
##########
@@ -1336,8 +1337,15 @@ protected RexLiteral makeLiteral(
o = ((TimestampWithTimeZoneString) o).round(p);
break;
case DECIMAL:
- if (o != null && type.getScale() != RelDataType.SCALE_NOT_SPECIFIED) {
- assert o instanceof BigDecimal;
+ if (o == null) {
Review Comment:
For non-constant expressions actual casting performed by `CastImplementor`
(see `RexToLixTranslator#checkExpressionPadTruncate`, there is multiplication
to time unit multiplier too). But if cast contains trivial expressions it can
be simplified to just literal, without call of `CastImplementor`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
