NobiGo commented on code in PR #4080:
URL: https://github.com/apache/calcite/pull/4080#discussion_r1874181680


##########
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##########
@@ -11692,9 +11683,9 @@ void assertSubFunReturns(boolean binary, String s, int 
start,
       f12.checkScalar("NVL2(NULL, 3.0, 2.111)", "2.111", "DECIMAL(4, 3) NOT 
NULL");
       f12.checkScalar("NVL2(3.111, 3.1415926, 2.111)", "3.1415926", 
"DECIMAL(8, 7) NOT NULL");
 
-      f12.checkNullValueWithNullableType("nvl2('ab', CAST(NULL AS VARCHAR(6)), 
'def')");
-      f12.checkNullValueWithNullableType("nvl2(NULL, 'abc', NULL)");
-      f12.checkNullValueWithNullableType("nvl2(NULL, NULL, NULL)");
+      f12.checkNull("nvl2('ab', CAST(NULL AS VARCHAR(6)), 'def')");

Review Comment:
   This PR makes `checknull` to support the check nullable type.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to