zabetak commented on code in PR #4083:
URL: https://github.com/apache/calcite/pull/4083#discussion_r1878061364
##########
testkit/src/main/java/org/apache/calcite/test/catalog/MockCatalogReader.java:
##########
@@ -651,11 +647,43 @@ public void addColumn(String name, RelDataType type) {
public void addColumn(String name, RelDataType type, boolean isKey) {
if (isKey) {
- keyList.add(columnList.size());
+ keyList.add(ImmutableBitSet.of(columnList.size()));
}
columnList.add(Pair.of(name, type));
}
+ public void addKey(String... columns) {
Review Comment:
The method adds one key (over possibly multiple columns) so using singular
noun seems more appropriate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
