mihaibudiu commented on code in PR #4085:
URL: https://github.com/apache/calcite/pull/4085#discussion_r1880608132
##########
elasticsearch/src/test/java/org/apache/calcite/adapter/elasticsearch/ElasticSearchAdapterTest.java:
##########
@@ -771,4 +771,24 @@ private static Consumer<ResultSet>
sortedResultSetChecker(String column,
"state=AR; EXPR$1=3; EXPR$2=3");
}
+ @Test
+ void testSortHosts() {
+ Map<String, Integer> hosts = new HashMap<>();
+ hosts.put("192.168.1.150",8080);
+ hosts.put("192.168.1.110",6080);
+ hosts.put("192.168.1.120",8080);
+
+
+ List<HttpHost> sortedHosts = hosts.entrySet()
Review Comment:
What @NobiGo means here is: you are testing the sorting method, but not the
elastic search. Ideally a unit test would show a bug related to elastic search
that is solved by this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
