zabetak commented on code in PR #4089:
URL: https://github.com/apache/calcite/pull/4089#discussion_r1882486060
##########
core/src/main/java/org/apache/calcite/rel/metadata/RelMdUniqueKeys.java:
##########
@@ -131,7 +159,7 @@ public Set<ImmutableBitSet> getUniqueKeys(Project rel,
RelMetadataQuery mq,
Util.transform(program.getProjectList(), program::expandLocalRef));
}
- private static Set<ImmutableBitSet> getProjectUniqueKeys(SingleRel rel,
RelMetadataQuery mq,
+ private Set<ImmutableBitSet> getProjectUniqueKeys(SingleRel rel,
RelMetadataQuery mq,
Review Comment:
For most use-cases we shouldn't hit the limit so I would say that it is not
that important. Moreover, it would be difficult to provide this information via
the regular result of the method. An alternative, that crossed my mind is
throwing an well defined exception when the limit is reached instead of
truncating but this may be a less desired behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
