mihaibudiu commented on code in PR #4098:
URL: https://github.com/apache/calcite/pull/4098#discussion_r1891004595
##########
core/src/test/java/org/apache/calcite/test/SqlValidatorTest.java:
##########
@@ -501,6 +501,19 @@ static SqlOperatorTable operatorTableFor(SqlLibrary
library) {
expr("^x'abcd'<>1^")
.fails("(?s).*Cannot apply '<>' to arguments of type "
+ "'<BINARY.2.> <> <INTEGER>'.*");
+ // Test cases for [CALCITE-6736] Validator accepts comparisons between
arrays, multisets, maps
+ // without regard to element types
+ expr("^array[x'a4'] = array[1]^")
Review Comment:
I assumed such tests exists, but didn't look too much. This change only
rejects some programs that used to be accepted, so I really focused on negative
tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
