NobiGo commented on code in PR #4102:
URL: https://github.com/apache/calcite/pull/4102#discussion_r1893381388
##########
core/src/test/java/org/apache/calcite/test/SqlValidatorTest.java:
##########
@@ -4480,7 +4480,7 @@ private void checkNegWindow(String s, String msg) {
expr("(1,2) in ((1,2), (3,4))")
.columnType("BOOLEAN NOT NULL");
expr("'medium' in (cast(null as varchar(10)), 'bc')")
- .columnType("BOOLEAN NOT NULL");
Review Comment:
In my opinion, this change is reasonable, but it's strange that it only
affects this test case. Do we need to add more test cases to cover the
corresponding changes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
