mihaibudiu commented on code in PR #4107:
URL: https://github.com/apache/calcite/pull/4107#discussion_r1894526065
##########
core/src/main/java/org/apache/calcite/adapter/enumerable/RexToLixTranslator.java:
##########
@@ -563,9 +563,15 @@ private Expression getConvertExpression(
case TINYINT:
case SMALLINT: {
if (SqlTypeName.NUMERIC_TYPES.contains(sourceType.getSqlTypeName())) {
+ Type javaClass = typeFactory.getJavaClass(targetType);
Review Comment:
This change is only indirectly related to this PR: without this change, the
code generated for ROW casts crashes at runtime.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
