mihaibudiu commented on code in PR #4104:
URL: https://github.com/apache/calcite/pull/4104#discussion_r1894555143
##########
core/src/main/java/org/apache/calcite/rel/metadata/RelMdPredicates.java:
##########
@@ -308,18 +308,11 @@ public RelOptPredicateList getPredicates(Filter filter,
RelMetadataQuery mq) {
final RexBuilder rexBuilder = filter.getCluster().getRexBuilder();
final RelOptPredicateList inputInfo = mq.getPulledUpPredicates(input);
- // Simplify condition using RexSimplify.
- final RexNode condition = filter.getCondition();
- final RexExecutor executor =
- Util.first(filter.getCluster().getPlanner().getExecutor(),
RexUtil.EXECUTOR);
- final RexSimplify simplify = new RexSimplify(rexBuilder,
RelOptPredicateList.EMPTY, executor);
- final RexNode simplifiedCondition = simplify.simplify(condition);
-
return Util.first(inputInfo, RelOptPredicateList.EMPTY)
.union(rexBuilder,
RelOptPredicateList.of(rexBuilder,
RexUtil.retainDeterministic(
- RelOptUtil.conjunctions(simplifiedCondition))));
+ RelOptUtil.conjunctions(filter.getCondition()))));
Review Comment:
yes, please change the PR and commit title, and perhaps link to the actual
JIRA issue that is being solved.
Otherwise this looks fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
