mihaibudiu commented on code in PR #4115:
URL: https://github.com/apache/calcite/pull/4115#discussion_r1898677234


##########
core/src/test/java/org/apache/calcite/rel/metadata/RelMdUtilTest.java:
##########
@@ -110,4 +117,39 @@ final RelMetadataFixture sql(String sql) {
     });
   }
 
+  /** Test case for
+   * <a 
href="https://issues.apache.org/jira/browse/CALCITE-6749";>[CALCITE-6749]
+   * RelMdUtil#setAggChildKeys may return an incorrect result</a>. */
+  @Test void testSetAggChildKeys() {

Review Comment:
   Frankly, this is hard to review.
   I saw the discussion in the JIRA, but it's not obvious at all that "9" is 
the right answer.
   I wonder whether having the full plan here would actually be easier - at 
least in a comment.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to