NobiGo commented on code in PR #4117:
URL: https://github.com/apache/calcite/pull/4117#discussion_r1900052583
##########
core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java:
##########
@@ -8616,6 +8616,20 @@ private void checkLiteral2(String expression, String
expected) {
.withSpark().ok(sparkExpected);
}
+ /** Test case for
+ * <a
href="https://issues.apache.org/jira/browse/CALCITE-6748";>[CALCITE-6748]
+ * RelToSqlConverter returns the wrong result when Aggregate is on Sort</a>.
*/
+ @Test void testAggregateOnSort() {
+ final String query = "select max(\"product_class_id\") "
+ + "from (select * from \"product\" order by \"brand_name\" asc limit
10) t";
Review Comment:
The unit test didn't cover `offset`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
