ILuffZhe commented on code in PR #4120:
URL: https://github.com/apache/calcite/pull/4120#discussion_r1901428834


##########
arrow/src/test/java/org/apache/calcite/adapter/arrow/ArrowDataTest.java:
##########
@@ -411,4 +420,14 @@ private void dateField(FieldVector fieldVector, int 
rowCount) {
     }
     fieldVector.setValueCount(rowCount);
   }
+
+  private void timeField(FieldVector fieldVector, int rowCount) {
+    TimeSecVector timeVector = (TimeSecVector) fieldVector;
+    timeVector.setInitialCapacity(rowCount);
+    timeVector.allocateNew();
+    for (int i = 0; i < rowCount; i++) {
+      timeVector.set(i, i * 1000);

Review Comment:
   You mean there exist unit that is not milliseconds? How do we handle this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to