joeyutong commented on code in PR #3844:
URL: https://github.com/apache/calcite/pull/3844#discussion_r1901592308
##########
core/src/main/java/org/apache/calcite/sql/type/ArrayElementOperandTypeChecker.java:
##########
@@ -95,6 +97,14 @@ public ArrayElementOperandTypeChecker(boolean
arrayMayBeNull, boolean elementMay
return false;
}
+
+ if (!arrayComponentType.equalsSansFieldNames(biggest)) {
Review Comment:
@mihaibudiu I think it is appropriate to do type casting in the type
checker, such as `checkOperandTypes` from `FamilyOperandTypeChecker` which
implements `ImplicitCastOperandTypeChecker`
[some background](https://github.com/apache/calcite/pull/706)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
