ILuffZhe commented on code in PR #4122:
URL: https://github.com/apache/calcite/pull/4122#discussion_r1902662418


##########
core/src/main/java/org/apache/calcite/sql/dialect/StarRocksSqlDialect.java:
##########
@@ -102,6 +102,26 @@ public StarRocksSqlDialect(Context context) {
               timeUnitNode.getParserPosition());
       SqlFloorFunction.unparseDatetimeFunction(writer, newCall, "DATE_TRUNC", 
false);
       break;
+    case EXTRACT:

Review Comment:
   Maybe we should do it in MySqlDialect since MySQL extract function also 
doesn't support DOW and DOY.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to