NobiGo commented on code in PR #4132:
URL: https://github.com/apache/calcite/pull/4132#discussion_r1908201067
##########
core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java:
##########
@@ -9093,6 +9093,18 @@ private void checkLiteral2(String expression, String
expected) {
sql(query).withOracle().ok(oracle);
}
+ /** Test case for
+ * <a
href="https://issues.apache.org/jira/browse/CALCITE-6771";>[CALCITE-6771]
+ * Convert Type from FLOAT to DOUBLE in PrestoDialect </a>. */
+ @Test void testPrestoCastToFloat() {
+ String query = "SELECT CAST(\"department_id\" AS float) FROM \"employee\"";
Review Comment:
I have already approved it, whether or not to make changes depends on you.
##########
core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java:
##########
@@ -9093,6 +9093,18 @@ private void checkLiteral2(String expression, String
expected) {
sql(query).withOracle().ok(oracle);
}
+ /** Test case for
+ * <a
href="https://issues.apache.org/jira/browse/CALCITE-6771";>[CALCITE-6771]
+ * Convert Type from FLOAT to DOUBLE in PrestoDialect </a>. */
+ @Test void testPrestoCastToFloat() {
+ String query = "SELECT CAST(\"department_id\" AS float) FROM \"employee\"";
Review Comment:
This looks redundant, can it be merged into one SQL statement？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
