stoty commented on code in PR #264:
URL: https://github.com/apache/calcite-avatica/pull/264#discussion_r1913258956
##########
build.gradle.kts:
##########
@@ -31,6 +31,20 @@ import de.thetaphi.forbiddenapis.gradle.CheckForbiddenApis
import de.thetaphi.forbiddenapis.gradle.CheckForbiddenApisExtension
import org.gradle.api.tasks.testing.logging.TestExceptionFormat
+buildscript {
+ dependencies {
+ constraints {
+ // Looks like we cannot access the versions defined in
gradle.properties from here
+ "classpath"("org.ow2.asm:asm:9.7.1")
+ "classpath"("org.ow2.asm:asm-all:9.7.1")
+ "classpath"("org.ow2.asm:asm-analysis:9.7.1")
+ "classpath"("org.ow2.asm:asm-commons:9.7.1")
+ "classpath"("org.ow2.asm:asm-tree:9.7.1")
+ "classpath"("org.ow2.asm:asm-util:9.7.1")
+ }
+ }
+}
+
Review Comment:
Unfortunately, those are not plugin versions.
These are overrides for the dependencies of a plugin.
And we cannot use a newer plugin, because this is the last version of the
shade plugin than runs on Java 8.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
