ILuffZhe commented on code in PR #4149:
URL: https://github.com/apache/calcite/pull/4149#discussion_r1919398817


##########
core/src/main/java/org/apache/calcite/runtime/CalciteResource.java:
##########
@@ -948,8 +948,8 @@ ExInst<CalciteException> 
illegalArgumentForTableFunctionCall(String a0,
   @BaseMessage("Illegal arguments: The length of the keys array {0,number,#} 
is not equal to the length of the values array {1,number,#} in MAP_FROM_ARRAYS 
function")
   ExInst<CalciteException> illegalArgumentsInMapFromArraysFunc(int arg0, int 
arg1);
 
-  @BaseMessage("Trim error: trim character must be exactly 1 character")

Review Comment:
   I've noticed that the former doc implies changing it to `Invalid 
argument...`.Since it is a strict rule in SQL standard, what about "Invalid 
argument ''{0}'' : the length of the string describing the trimmed character 
must be 1".



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to