kramerul commented on code in PR #3562:
URL: https://github.com/apache/calcite/pull/3562#discussion_r1923153817
##########
core/src/main/java/org/apache/calcite/adapter/jdbc/JdbcImplementor.java:
##########
@@ -18,20 +18,66 @@
import org.apache.calcite.adapter.java.JavaTypeFactory;
import org.apache.calcite.rel.RelNode;
+import org.apache.calcite.rel.core.CorrelationId;
import org.apache.calcite.rel.rel2sql.RelToSqlConverter;
+import org.apache.calcite.rel.rel2sql.SqlImplementor;
+import org.apache.calcite.rel.type.RelDataTypeField;
+import org.apache.calcite.rex.RexCorrelVariable;
import org.apache.calcite.sql.SqlDialect;
-import org.apache.calcite.util.Util;
+import org.apache.calcite.sql.SqlDynamicParam;
+import org.apache.calcite.sql.SqlNode;
+import org.apache.calcite.sql.parser.SqlParserPos;
+
+import java.lang.reflect.Type;
+import java.util.List;
/**
* State for generating a SQL statement.
*/
public class JdbcImplementor extends RelToSqlConverter {
- public JdbcImplementor(SqlDialect dialect, JavaTypeFactory typeFactory) {
+
+ private final JdbcCorrelationDataContextBuilder dataContextBuilder;
+ private final JavaTypeFactory typeFactory;
+
+ public JdbcImplementor(SqlDialect dialect, JavaTypeFactory typeFactory,
Review Comment:
I changed the new constructor to package private.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
