stoty commented on PR #268: URL: https://github.com/apache/calcite-avatica/pull/268#issuecomment-2611685052
Having a single binary that works with all JVMs is the only solution that doesn't require extra steps from users. For example, we want users to be able to update their JVM from 17 to 23, without having to replace JARs, and want to avoid having JVM specific distributions both for Avatica, and its dependencies. This is also the approach taken by projects that I am aware of. As for testing, running the test suite cross-JVM would be nice, especially as the suite is not expensive. I don't think it's critical though, as every code path uses reflectcion, so the existing tests already give us full coverage. We should definitely bump the JDK22 CI run to use JDK23; either in the JDK23 support patch, or in separate JIRA. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
