rubenada commented on code in PR #4172:
URL: https://github.com/apache/calcite/pull/4172#discussion_r1933462900
##########
core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java:
##########
@@ -359,6 +359,22 @@ public static ByteString fromHex(String hex) {
}
}
+ /** SQL HEX(varchar) function. */
Review Comment:
nit: could you please put the new methods after the existing `toHex` method
definition? I'd like to keep "related" methods (fromHex/toHex) right next to
each other (similarly to the new ones hex/unhex).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
