xuzifu666 commented on code in PR #4176:
URL: https://github.com/apache/calcite/pull/4176#discussion_r1942136866


##########
core/src/main/java/org/apache/calcite/sql/fun/SqlLibraryOperators.java:
##########
@@ -1855,6 +1855,19 @@ private static RelDataType 
deriveTypeMapFromEntries(SqlOperatorBinding opBinding
           OperandTypes.STRING.or(OperandTypes.BINARY),
           SqlFunctionCategory.STRING);
 
+  @LibraryOperator(libraries = {HIVE})
+  public static final SqlFunction BASE64 =
+      SqlBasicFunction.create("BASE64",
+          ReturnTypes.VARCHAR_NULLABLE,

Review Comment:
   According to @ILuffZhe suggestions: BASE64 reuse TO_BASE64 function and 
UN_BASE64 reuse FROM_BASE64, so ReturnTypes keep the same with TO_BASE64 and 
UN_BASE64 , they are VARCHAR_NULLABLE and VARBINARY_FORCE_NULLABLE which had 
the same behavior in Hive. @caicancai 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to