ILuffZhe commented on code in PR #275:
URL: https://github.com/apache/calcite-avatica/pull/275#discussion_r1948279544
##########
core/src/test/java/org/apache/calcite/avatica/AvaticaResultSetThrowsSqlExceptionTest.java:
##########
@@ -145,28 +145,46 @@ private boolean getColumn(final ResultSet resultSet,
final int index,
case 3: // SMALLINT
resultSet.getShort(index);
break;
- case 4: // INTEGER
+ case 4: // MEDIUMINT
resultSet.getInt(index);
break;
- case 5: // BIGINT
+ case 5: // INTEGER
Review Comment:
case 4 and case 5 can be merged
##########
core/src/main/java/org/apache/calcite/avatica/AvaticaSite.java:
##########
@@ -291,7 +291,7 @@ public void setObject(Object x, int targetSqlType) {
/** Similar logic to {@link #setObject}. */
public static Object get(Cursor.Accessor accessor, int targetSqlType,
- Calendar localCalendar) throws SQLException {
+ boolean signed, Calendar localCalendar) throws
SQLException {
Review Comment:
Nit: the indent, so are the following changes below in MetaImpl.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
