kramerul commented on code in PR #4100: URL: https://github.com/apache/calcite/pull/4100#discussion_r1949253267
########## core/src/main/java/org/apache/calcite/adapter/jdbc/JdbcBaseSchema.java: ########## @@ -0,0 +1,94 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to you under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.calcite.adapter.jdbc; + +import org.apache.calcite.linq4j.tree.Expression; +import org.apache.calcite.rel.type.RelProtoDataType; +import org.apache.calcite.schema.Function; +import org.apache.calcite.schema.Schema; +import org.apache.calcite.schema.SchemaPlus; +import org.apache.calcite.schema.SchemaVersion; +import org.apache.calcite.schema.Schemas; +import org.apache.calcite.schema.Table; +import org.apache.calcite.schema.lookup.LikePattern; +import org.apache.calcite.schema.lookup.Lookup; + +import org.checkerframework.checker.nullness.qual.Nullable; + +import java.util.Collection; +import java.util.Collections; +import java.util.Set; + +import static java.util.Objects.requireNonNull; + +/** + * Base class for JDBC schemas. + */ +public abstract class JdbcBaseSchema implements Schema { + + @Override public abstract Lookup<Table> tables(); + + + @Override public @Nullable Table getTable(String name) { + return tables().get(name); + } + + @Override public Set<String> getTableNames() { Review Comment: No this is not possible. The newly introduced functions `tables()` and `subSchemas()` must have a default implementation. Moving the implementation of `getTableNames()` to `Schema` will result in a stack overflow because `getTableNames()` -> `tables()` -> `getTableNames()` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
