chrisdennis commented on code in PR #272:
URL: https://github.com/apache/calcite-avatica/pull/272#discussion_r1951596487
##########
core/src/main/java/org/apache/calcite/avatica/util/Sources.java:
##########
@@ -136,8 +136,7 @@ private static URL fileToUrl(File file) {
// We need to encode path. For instance, " " should become "%20"
Review Comment:
No, probably not. Removed... but closer inspection here forced me to fix
something else. This branch of the code is making a very "odd" URI/URL. It's a
hierarchical URI, with a relative path and a scheme. I don't know if they're
illegal under the RFC... but it's certainly weird. I had to subtly tweak things
here to construct one by treating it as a non-heirarchical URL (args here are:
scheme, scheme-specific-part, fragment). The behavior now matches the old code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
