mihaibudiu commented on code in PR #4198:
URL: https://github.com/apache/calcite/pull/4198#discussion_r1962290311
##########
core/src/main/java/org/apache/calcite/rel/type/RelDataTypeSystemImpl.java:
##########
@@ -357,6 +358,27 @@ && getDefaultPrecision(typeName) !=
RelDataType.PRECISION_NOT_SPECIFIED) {
argumentType.isNullable());
}
}
+ // For DECIMAL using default Precision and Scale,
Review Comment:
as discussed in the JIRA, the right approach is to actually create a new
type system that overrides this method rather than change RelDataTypeSystemImpl.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
