rubenada commented on PR #4207: URL: https://github.com/apache/calcite/pull/4207#issuecomment-2673893486
Thanks for creating this PR @xiedeyantu . I'd suggest to take a look at our [contributing](https://calcite.apache.org/develop/#contributing) guidelines to know a bit more about our conventions (e.g. create a Jira ticket, do not end commit message with a period, describe the issue rather than using "Fix..." on the Jira title and commit message, etc.). About this particular patch, I have quickly looked into it, and it seems a potentially valid (minor) issue, basically the "if" block is never executed because the `RelNode stripped` is actually not stripped, e.g. it would be a HepRelVertex (or Volcano's RelSubset) instead of the actual Project inside of it. The consequence of this is minor (the rule's result rowType will have the bottom's Project fieldnames instead of the top Project's). IMO the Jira title / commit message should describe this circumstance. As @suibianwanwank mentioned, probably RelOptRulesTest is the easiest place to produce a unit test showing the issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
