mihaibudiu commented on code in PR #4210:
URL: https://github.com/apache/calcite/pull/4210#discussion_r1969225066
##########
core/src/test/java/org/apache/calcite/test/SqlToRelConverterTest.java:
##########
@@ -5388,6 +5390,23 @@ void checkUserDefinedOrderByOver(NullCollation
nullCollation) {
.ok();
}
+ @Test void testNestedWindowAggWithIdentifierExpansionDisabled() {
+ String sql = "select sum(sum(sal)) over() from emp";
+ sql(sql)
+ .withFactory(f ->
+ f.withValidator((opTab, catalogReader, typeFactory, config) -> {
+ if (config.conformance().allowGeometry()) {
Review Comment:
what is the connection with the geometry?
##########
core/src/main/java/org/apache/calcite/sql2rel/SqlToRelConverter.java:
##########
@@ -2328,6 +2328,7 @@ private RexNode convertOver(Blackboard bb, SqlNode node) {
"already in window agg mode");
bb.window = window;
RexNode rexAgg = exprConverter.convertCall(bb, aggCall);
+ bb.getValidator().deriveType(bb.scope, call);
Review Comment:
a little higher up the code uses `validator().deriveType()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
