xuzifu666 commented on code in PR #3696:
URL: https://github.com/apache/calcite/pull/3696#discussion_r1969736817
##########
elasticsearch/src/main/java/org/apache/calcite/adapter/elasticsearch/ElasticsearchRules.java:
##########
@@ -113,8 +113,7 @@ static List<String> elasticsearchFieldNames(final
RelDataType rowType) {
return SqlValidatorUtil.uniquify(
new AbstractList<String>() {
@Override public String get(int index) {
- final String name = rowType.getFieldList().get(index).getName();
- return name.startsWith("$") ? "_" + name.substring(2) : name;
Review Comment:
I had test join operation of elasticsearch，it would return empty result.
here name.substring(2) is not right which maybe copy from mongodb(mongodb is
$_f1 and elasticsearch is $f1),and here not necessary to do this
operation，return rowType.getFieldList().get(index).getName() directly is OK
@mihaibudiu @NobiGo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
