xuzifu666 commented on code in PR #4202:
URL: https://github.com/apache/calcite/pull/4202#discussion_r1971046295


##########
core/src/main/java/org/apache/calcite/sql/fun/SqlLibraryOperators.java:
##########
@@ -1508,21 +1508,21 @@ private static RelDataType 
arrayCompactReturnType(SqlOperatorBinding opBinding)
           OperandTypes.AT_LEAST_ONE_SAME_VARIADIC);
 
   /** The "ARRAY_CONTAINS(array, element)" function. */
-  @LibraryOperator(libraries = {SPARK})
+  @LibraryOperator(libraries = {SPARK, HIVE})

Review Comment:
   > ```
   > select array_contains(array(1,null),2);
   > ```
   > 
   > In Spark, returns NULL But In Hive, it returns FALSE This cannot be the 
same function.
   
   According discussion with Spark community offline,this is a bug of spark,and 
here array_contains(array(1,null),2) should return false not null, at the same 
time test array_contains(array(1, null),1) would return true in Spark,can we 
not consider about it currently?other functions test is well with different 
parameters.  @NobiGo 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to