asolimando commented on code in PR #4227:
URL: https://github.com/apache/calcite/pull/4227#discussion_r1984967975
##########
druid/src/main/java/org/apache/calcite/adapter/druid/DruidQuery.java:
##########
@@ -120,6 +120,12 @@ public class DruidQuery extends AbstractRelNode implements
BindableRel {
.add(new DirectOperatorConversion(SqlStdOperatorTable.SIN, "sin"))
.add(new DirectOperatorConversion(SqlStdOperatorTable.COS, "cos"))
.add(new DirectOperatorConversion(SqlStdOperatorTable.TAN, "tan"))
+ .add(new DirectOperatorConversion(SqlStdOperatorTable.COT, "cot"))
+ .add(new DirectOperatorConversion(SqlStdOperatorTable.ASIN, "asin"))
+ .add(new DirectOperatorConversion(SqlStdOperatorTable.ACOS, "acos"))
+ .add(new DirectOperatorConversion(SqlStdOperatorTable.ATAN, "atan"))
+ .add(new DirectOperatorConversion(SqlStdOperatorTable.ATAN2,
"atan2"))
+ .add(new DirectOperatorConversion(SqlStdOperatorTable.DEGREES,
"degrees"))
Review Comment:
I'd rather leave a disabled unit test with a comment so people are aware of
the problem, it's less probable that they will come check here IMO
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
