mihaibudiu commented on code in PR #4234:
URL: https://github.com/apache/calcite/pull/4234#discussion_r1986367231
##########
core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java:
##########
@@ -8099,14 +8099,24 @@ private void checkLiteral2(String expression, String
expected) {
+ "FROM \"foodmart\".\"product\"";
final String expectedStarRocksSql = "SELECT
APPROX_COUNT_DISTINCT(`product_id`)\n"
+ "FROM `foodmart`.`product`";
+ final String expectedMssql = "SELECT APPROX_COUNT_DISTINCT([product_id])\n"
+ + "FROM [foodmart].[product]";
+ final String expectedPhoenix = "SELECT
APPROX_COUNT_DISTINCT(\"product_id\")\n"
Review Comment:
is this exactly the same as ApproxQuota above?
Is there a benefit having two identical strings?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
