xiedeyantu commented on code in PR #4236:
URL: https://github.com/apache/calcite/pull/4236#discussion_r1992401524
##########
core/src/test/java/org/apache/calcite/test/RelOptRulesTest.java:
##########
@@ -3527,6 +3527,38 @@ private void
checkPushJoinThroughUnionOnRightDoesNotMatchSemiOrAntiJoin(JoinRelT
.check();
}
+ /** Test case for <a
href="https://issues.apache.org/jira/browse/CALCITE-6880">
+ * [CALCITE-6880] Implement IntersectToSemiJoinRule</a>. */
Review Comment:
> Please add a test case where the intersected sets do not have exactly the
same column types. Coercion should take care of it, but let's make sure.
OK, I will add test for it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]