xuzifu666 commented on code in PR #4242:
URL: https://github.com/apache/calcite/pull/4242#discussion_r1992726525
##########
core/src/main/java/org/apache/calcite/rel/rules/ReduceExpressionsRule.java:
##########
@@ -738,6 +740,20 @@ protected static boolean reduceExpressionsInternal(RelNode
rel,
// Replace predicates on CASE to CASE on predicates.
boolean changed = new CaseShuttle().mutate(expList);
+ // distinct for IN rexNode
+ for (RexNode rexNode : predicates.pulledUpPredicates) {
+ if (rexNode.isA(SqlKind.IN)) {
+ RexSubQuery rexSubQuery = (RexSubQuery) rexNode;
+ List<ImmutableList<RexLiteral>> collect =
+ ((LogicalValues) rexSubQuery.rel).tuples
+ .stream().distinct().collect(Collectors.toList());
+ // In would transform to RexSubQuery and rel should be LogicalValues
+ if (rexSubQuery.rel instanceof LogicalValues) {
+ ((LogicalValues) rexSubQuery.rel).tuples =
ImmutableList.copyOf(collect);
Review Comment:
@mihaibudiu According my analysis，there is a problem create a new object of
SubQuery instead of mutating the fields of a subquery ,since
pulledUpPredicates is final ImmutableList<RexNode>. Maybe we cannot change the
construct of predicate by this way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
