NobiGo commented on code in PR #4237:
URL: https://github.com/apache/calcite/pull/4237#discussion_r1994986344
##########
core/src/main/java/org/apache/calcite/sql/fun/SqlLibrary.java:
##########
@@ -85,7 +85,10 @@ public enum SqlLibrary {
SNOWFLAKE("f", "snowflake"),
/** A collection of operators that are in Apache Spark but not in standard
* SQL. */
- SPARK("s", "spark");
+ SPARK("s", "spark"),
+ /** A collection of operators that are in Apache Druid but not in standard
+ * SQL. */
+ DRUID("d", "druid");
Review Comment:
We shouldn't add DRUID as a SqlLibrary. DRUID is not a Jdbc database. Each
adapter has a specific section that indicates which functions are supported and
which are not by the current adapter. This is because only the supported
functions can enable some API conversions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
